Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr/fcsCosmic-2ndTry #58

Merged
merged 1 commit into from
Aug 2, 2021
Merged

pr/fcsCosmic-2ndTry #58

merged 1 commit into from
Aug 2, 2021

Conversation

akioogawa
Copy link
Contributor

Updates StFcsClusterMaker for cosmic "tracking" (sort by id instead of energy)
New StFcsCosmicMaker in StRoot/SpinPool
Associated updates in StFcsEventDisplay and macros
Added "obsolete" comments on how-to for FCS software from CVS era
Results are available at https://www.star.bnl.gov/protected/spin/akio/fcs/construction/cosmic/

…f energy)

New StFcsCosmicMaker in StRoot/SpinPool
Associated updates in StFcsEventDisplay and macros
Added "obsolete" comments on how-to for FCS software from CVS era
Results are available at https://www.star.bnl.gov/protected/spin/akio/fcs/construction/cosmic/
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@plexoos
Copy link
Member

plexoos commented Jul 19, 2021

@zlchang, any comments?

@veprbl veprbl requested a review from jdbrice July 19, 2021 18:13
@veprbl
Copy link
Member

veprbl commented Jul 26, 2021

Let's merge unless there are further comments

@akioogawa
Copy link
Contributor Author

zlchang or jdbrice?

@zlchang
Copy link
Member

zlchang commented Aug 2, 2021

zlchang or jdbrice?

Hi Akio, I already approved your request

@plexoos plexoos merged commit 518e8c5 into star-bnl:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants