Fix issues when compiling against ROOT6 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These classes are processed by ROOT to create streamers. Unlike rootcint in ROOT5, rootcling seemingly respects the access modifiers and needs all types to be publicly defined. [StTofHitMaker, StJetMaker]
fgeurts
approved these changes
Jun 2, 2021
StAutoBrowse conflicts with ROOT6 and seems to be an outdated wrapper around the ROOT TBrowser. Users can invoke TBrowser directly in their interactive ROOT sessions
plexoos
requested review from
akioogawa,
jdbrice,
klendathu2k,
nigmatkulov,
starsdong,
ullrich-bnl,
veprbl and
zlchang
as code owners
|
Regarding changes to StRoot/StEvent/StEmcDetector.cxx I have never understood the purpose of (or history behind) StAutoBrowse. Changes look harmless / touch functionality, not event model. However, this code is in StEvent, and so @ullrich-bnl should review. |
|
It is written by me. It is automatic Browser, to avoid manual encoding
all included classes.
It was not implemented in ROOT. Later Rene add this functionality in
ROOT.
Now it is possible to remove.
Victor
…On 2021-06-25 13:08, klendathu2k wrote:
Regarding changes to StRoot/StEvent/StEmcDetector.cxx
I have never understood the purpose of (or history behind)
StAutoBrowse. Changes look harmless / touch functionality, not event
model. However, this code is in StEvent, and so @ullrich-bnl [1]
should review.
--
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
Links:
------
[1] https://github.com/ullrich-bnl
[2] #6 (comment)
[3]
https://github.com/notifications/unsubscribe-auth/ANQUL7KZF524EO6543PVGNLTUSZ2NANCNFSM455HPCUA
|
|
Any more approvals from the code owners? |
|
If I don't hear any further comments from anyone including @ullrich-bnl I'll merge this PR tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike rootcint, rootcling in ROOT6 seems to be mindful of the access modifiers for nested types used to declare data members. Such types should have public access