Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Include StRoot/StFgtPool into CI build #86

Merged
merged 2 commits into from
Aug 6, 2021
Merged

[ci] Include StRoot/StFgtPool into CI build #86

merged 2 commits into from
Aug 6, 2021

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Aug 6, 2021

No description provided.

veprbl
veprbl approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@plexoos
Copy link
Member Author

plexoos commented Aug 6, 2021

You should have waited for ROOT6 to finish 😸 It can end up like #83

@veprbl
Copy link
Member

veprbl commented Aug 6, 2021

Well, CI failures are not end of the world :)
My main thought was that an StMaker has no business with curses, so it's nice that you've caught this.

@plexoos
Copy link
Member Author

plexoos commented Aug 6, 2021

Merge this trivial fix as there are no designated code owners for StRoot/StFgtPool

@plexoos plexoos merged commit ee177ac into main Aug 6, 2021
@plexoos plexoos deleted the ds-ci-build-StFgtPool branch August 6, 2021 17:51
@plexoos plexoos mentioned this pull request Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov nigmatkulov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plexoos @veprbl