Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): cmp results use multi table in datastore #1030

Merged
merged 3 commits into from
Aug 28, 2022
Merged

fix(client): cmp results use multi table in datastore #1030

merged 3 commits into from
Aug 28, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 28, 2022 •
edited
Loading

Description

  1. cmp metrics use multi table store
    image
  2. solve the cmd swcli eval info {version} display problem
    image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing self-assigned this Aug 28, 2022
@goldenxinxing goldenxinxing added bug 🐛 Something isn't working client 🌈 labels Aug 28, 2022
@goldenxinxing goldenxinxing added this to the v0.3 milestone Aug 28, 2022
tianweidut
tianweidut approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit c894529 into star-whale:main Aug 28, 2022
@goldenxinxing goldenxinxing deleted the fix/cmp_result_use_multitable branch September 13, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@xuchuan xuchuan Awaiting requested review from xuchuan

Assignees

@goldenxinxing goldenxinxing

Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @tianweidut