Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataset): support dataset mime_type config #1033

Merged
merged 1 commit into from
Aug 28, 2022
Merged

feat(dataset): support dataset mime_type config #1033

merged 1 commit into from
Aug 28, 2022

Conversation

tianweidut
Copy link
Member

Description

  • add mime_type for every row

cc @waynelwz

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Aug 28, 2022
@tianweidut tianweidut self-assigned this Aug 28, 2022
@tianweidut tianweidut mentioned this pull request Aug 28, 2022
Merged
4 tasks
anda-ren
anda-ren approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 9996167 into star-whale:main Aug 28, 2022
@tianweidut tianweidut deleted the feat/dataset-mime-type branch April 17, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anda-ren anda-ren anda-ren approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

@goldenxinxing goldenxinxing Awaiting requested review from goldenxinxing

Assignees

@tianweidut tianweidut

Labels
dataset🐫 feature ✨ new feature
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @anda-ren