Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job): tune eval info classification ui for standalone #1219

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 15, 2022

Description

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Sep 15, 2022
@tianweidut tianweidut self-assigned this Sep 15, 2022
@tianweidut tianweidut added this to In progress in Starwhale Product via automation Sep 15, 2022
@tianweidut tianweidut changed the title WIP feat(eval): tune eval info classification ui for standalone WIP feat(job): tune eval info classification ui for standalone Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1219 (1767b74) into main (ba0710e) will increase coverage by 10.10%.
The diff coverage is 10.00%.

❗ Current head 1767b74 differs from pull request most recent head 4ab8594. Consider uploading reports for the commit 4ab8594 to get more accurate results

@@              Coverage Diff              @@
##               main    #1219       +/-   ##
=============================================
+ Coverage     70.89%   80.99%   +10.10%     
=============================================
  Files           284       62      -222     
  Lines         13098     6941     -6157     
  Branches        637        0      -637     
=============================================
- Hits           9286     5622     -3664     
+ Misses         3615     1319     -2296     
+ Partials        197        0      -197     
Flag Coverage Δ
controller ?
standalone 80.99% <10.00%> (-0.76%) ⬇️
unittests 80.99% <10.00%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/metric.py 19.67% <0.00%> (-1.02%) ⬇️
client/starwhale/core/eval/view.py 65.43% <50.00%> (-0.49%) ⬇️
client/starwhale/core/dataset/type.py 82.85% <0.00%> (-16.75%) ⬇️
client/starwhale/base/view.py 80.21% <0.00%> (-2.68%) ⬇️
client/starwhale/base/uri.py 95.06% <0.00%> (-0.62%) ⬇️
client/starwhale/base/bundle_copy.py 93.79% <0.00%> (-0.13%) ⬇️
client/starwhale/base/bundle.py 91.24% <0.00%> (-0.07%) ⬇️
...tarwhale/mlops/api/protocol/project/ProjectVo.java
...hale/mlops/api/protocol/runtime/RuntimeInfoVo.java
...ain/java/ai/starwhale/mlops/api/EnvController.java
... and 220 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut changed the title WIP feat(job): tune eval info classification ui for standalone feat(job): tune eval info classification ui for standalone Sep 15, 2022
@tianweidut tianweidut requested review from goldenxinxing and jialeicui and removed request for goldenxinxing September 15, 2022 14:53
@tianweidut tianweidut changed the title feat(job): tune eval info classification ui for standalone WIP feat(job): tune eval info classification ui for standalone Sep 16, 2022
@tianweidut tianweidut changed the title WIP feat(job): tune eval info classification ui for standalone feat(job): tune eval info classification ui for standalone Sep 16, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starwhale Product automation moved this from In progress to Reviewer approved Sep 16, 2022
@goldenxinxing goldenxinxing merged commit 7e5bd6a into star-whale:main Sep 16, 2022
Starwhale Product automation moved this from Reviewer approved to Done Sep 16, 2022
@tianweidut tianweidut deleted the enhance/classification-ui branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants