-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(controller): refine the abstract layer between job and k8s #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k id from container label; deliver cancelling status from docker impl to status machine; clear scheduler.stop semantics;
anda-ren
force-pushed
the
abs_job_merge
branch
from
August 10, 2023 07:27
e5a0adc
to
5da7ee8
Compare
anda-ren
force-pushed
the
abs_job_merge
branch
from
August 10, 2023 08:05
7c55fb8
to
360e002
Compare
server/controller/src/main/java/ai/starwhale/mlops/domain/upgrade/step/UpdateK8sImage.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2604 +/- ##
============================================
- Coverage 82.64% 74.05% -8.59%
- Complexity 2683 2734 +51
============================================
Files 454 364 -90
Lines 24882 13214 -11668
Branches 1509 1519 +10
============================================
- Hits 20563 9786 -10777
+ Misses 3654 2745 -909
- Partials 665 683 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jialeicui
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gains
swcli server start
command possibleImplementation Changes
Limitations && TODOs
Modules
Checklist