Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): alter event msg type to text #3136

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Feb 4, 2024

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d3eaac) 83.03% compared to head (784e732) 73.65%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3136      +/-   ##
============================================
- Coverage     83.03%   73.65%   -9.39%     
+ Complexity     3244     3243       -1     
============================================
  Files           575      433     -142     
  Lines         32297    15814   -16483     
  Branches       1895     1834      -61     
============================================
- Hits          26819    11648   -15171     
+ Misses         4643     3334    -1309     
+ Partials        835      832       -3     
Flag Coverage Δ
console ?
controller 73.65% <ø> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit ee6a2b7 into star-whale:main Feb 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants