Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Document and REST API swagger output, plus related edits for … #261

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Updated Document and REST API swagger output, plus related edits for … #261

merged 4 commits into from
Jul 12, 2023

Conversation

johnsmartco
Copy link
Contributor

…2.0.13

@johnsmartco johnsmartco self-assigned this Jul 11, 2023
@johnsmartco johnsmartco added documentation Improvements or additions to documentation Document API REST API v2 labels Jul 11, 2023
@johnsmartco johnsmartco added this to the Ready for Merge milestone Jul 11, 2023
@johnsmartco
Copy link
Contributor Author

Temp output on internal coppi server:

http://coppi-ssh.aws.dsinternal.org/en/rest-doc-api-updates/latest/core-index.html
http://coppi-ssh.aws.dsinternal.org/en/rest-doc-api-updates/latest/develop/_attachments/docv2.html
http://coppi-ssh.aws.dsinternal.org/en/rest-doc-api-updates/latest/develop/_attachments/restv2.html
http://coppi-ssh.aws.dsinternal.org/en/rest-doc-api-updates/latest/develop/dev-with-doc.html
http://coppi-ssh.aws.dsinternal.org/en/rest-doc-api-updates/latest/develop/dev-with-rest.html
http://coppi-ssh.aws.dsinternal.org/en/rest-doc-api-updates/latest/develop/tooling.html#using-the-swagger-ui

kathirsvn
kathirsvn reviewed Jul 12, 2023
View reviewed changes
docs-src/.DS_Store Outdated Show resolved Hide resolved
kathirsvn
kathirsvn reviewed Jul 12, 2023
View reviewed changes
api/StargateDocv2.yaml Outdated Show resolved Hide resolved
kathirsvn
kathirsvn approved these changes Jul 12, 2023
View reviewed changes
Copy link

@kathirsvn kathirsvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsmartco I left some minor suggestions, over all LGTM.

@johnsmartco johnsmartco merged commit 707f56c into main Jul 12, 2023
@johnsmartco johnsmartco deleted the rest-doc-api-updates branch July 12, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathirsvn kathirsvn kathirsvn approved these changes

@jeffreyscarpenter jeffreyscarpenter Awaiting requested review from jeffreyscarpenter

Assignees

@johnsmartco johnsmartco

Labels
Document API documentation Improvements or additions to documentation REST API v2
Projects
None yet
Milestone
Ready for Merge
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsmartco @kathirsvn