bug: cairo_filesystem detect_corelib fails when used as a git dependency

[shramee]

Bug Report

Cairo version:

74b4d12

Current behavior:

thread 'main' panicked at 'Corelib not found.', /Users/shramee/.cargo/git/checkouts/cairo-f086c7e6d4098a68/74b4d12/crates/cairo-filesystem/src/detect.rs:34:5

When using cairo_compiler::db::RootDatabase; to get default let mut db_val = RootDatabase::default();

Using crates from the git repo like so,

# . . .
[dependencies]

# Members of starkware-libs/cairo
# . . .
cairo-filesystem = { git = "https://github.com/starkware-libs/cairo" }
cairo-compiler = { git = "https://github.com/starkware-libs/cairo" }
# . . .

Expected behavior:

Corelib dir to be found from installed git crate path.

Steps to reproduce:

Related code:

Tiniest reproducible version:

Issue is in cairo_filesystem::detect::detect_corelib.

Cargo.toml

[package]
name = "cairo-corelibs-bug"
version = "0.1.0"
edition = "2021"

[dependencies]
cairo-filesystem = { git = "https://github.com/starkware-libs/cairo" }

[[bin]]
name = "test"
path = "test.rs"

test.rs

use cairo_filesystem::detect::detect_corelib;
fn main() {
    let path = detect_corelib();
    print!("Found corelibs at {:#?}.", path);
}

Other information:

[mkaput]

@maciektr will work on this. Our goal is to provide an API to provide custom paths to the corelib and in the future I foresee giving an ability to provide the corelib via virtual filesystem objects.

[shramee]

I second virtual FS corelib. Projects shouldn't have to include corelibs in their project files. Those should fall back corelibs from the main workspace.

[spapinistarkware]

I think this is fixed now. You can probably check out how Scarb are doing it. If it's still an issue, I'll reopen