Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add closing parenthesis to methods completion #6380

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dean-starkware
Copy link
Collaborator

@dean-starkware dean-starkware commented Sep 16, 2024

This change is Reviewable

Copy link
Collaborator Author

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #5935

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @gilbens-starkware, @mkaput, @orizi, and @piotmag769)

Copy link
Collaborator

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @gilbens-starkware, @mkaput, @orizi, and @piotmag769)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @mkaput, @orizi, and @piotmag769)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @dean-starkware, and @mkaput)


crates/cairo-lang-language-server/tests/e2e/completions.rs line 68 at r1 (raw file):

                    if let Some(text) = completion.insert_text {
                        report.push_str(format!("Insert text: {}\n", text).as_str());
                    }

Suggestion:

                    report.push_str(format!("Completion: {}\n", completion.label).as_str());
                    if let Some(text) = completion.insert_text {
                        report.push_str(format!("Insert text: {text}\n").as_str());
                    }

Copy link
Collaborator Author

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @mkaput, and @orizi)


crates/cairo-lang-language-server/tests/e2e/completions.rs line 68 at r1 (raw file):

                    if let Some(text) = completion.insert_text {
                        report.push_str(format!("Insert text: {}\n", text).as_str());
                    }

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @mkaput)

@dean-starkware dean-starkware added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 883047e Sep 19, 2024
43 checks passed
@orizi orizi deleted the dean/improved_methods_completion branch September 19, 2024 14:52
dean-starkware added a commit that referenced this pull request Oct 8, 2024
add closing parenthesis to methods completion (#6380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert right paren after cursor when completing funciton/method calls
5 participants