Refactored setting constant and returning statement together. #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2024
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
from
addf1f6
to
1803e96
Compare
orizi
force-pushed
the
spr/main/5850139f
branch
2 times, most recently
from
66d5f49
to
be1a334
Compare
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
from
1803e96
to
a6c392f
Compare
This was referenced Oct 6, 2024
orizi
force-pushed
the
spr/main/5850139f
branch
from
be1a334
to
3b03bed
Compare
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
from
a6c392f
to
8186f69
Compare
gilbens-starkware
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
orizi
force-pushed
the
spr/main/5850139f
branch
from
3b03bed
to
7da4fc6
Compare
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
from
8186f69
to
2475864
Compare
orizi
force-pushed
the
spr/main/5850139f
branch
from
7da4fc6
to
14765df
Compare
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
from
2475864
to
1dc0420
Compare
orizi
force-pushed
the
spr/main/5850139f
branch
from
14765df
to
79f69b9
Compare
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
2 times, most recently
from
28bde09
to
6929646
Compare
orizi
force-pushed
the
spr/main/5850139f
branch
from
79f69b9
to
0fa21d5
Compare
gilbens-starkware
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
commit-id:4ed0b4d0
orizi
force-pushed
the
spr/main/4ed0b4d0
branch
from
6929646
to
79d8afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
*_eqwith 0 into*_iz_zero. #6454This change is