feat: use gateway config in mempool config #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
ArniStarkware
force-pushed
the
arni/config/gateway/create_config_file
branch
from
a60cc4b
to
ebf7b2f
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
0ff40fa
to
31d798d
Compare
This was referenced May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## arni/config/gateway/create_config_file #155 +/- ##
==========================================================================
+ Coverage 53.91% 54.17% +0.26%
==========================================================================
Files 21 21
Lines 766 766
Branches 766 766
==========================================================================
+ Hits 413 415 +2
+ Misses 334 333 -1
+ Partials 19 18 -1 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/config/gateway/create_config_file
branch
from
ebf7b2f
to
740ebdb
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
31d798d
to
9dbd6d0
Compare
|
+reviewer:@dafnamatsry +reviewer:@Yael-Starkware |
dafnamatsry
approved these changes
May 22, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
ArniStarkware
force-pushed
the
arni/config/gateway/create_config_file
branch
from
740ebdb
to
09915aa
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
9dbd6d0
to
26e9410
Compare
ArniStarkware
force-pushed
the
arni/config/gateway/create_config_file
branch
from
09915aa
to
17accb3
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
26e9410
to
c8a1e02
Compare
ArniStarkware
force-pushed
the
arni/config/gateway/create_config_file
branch
from
17accb3
to
312c209
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
c8a1e02
to
265e5f2
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
265e5f2
to
3042051
Compare
ArniStarkware
changed the base branch from
arni/config/gateway/create_config_file
to
main
dafnamatsry
approved these changes
May 23, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is