Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove redundent mempool node config tests #165

Merged
merged 1 commit into from
May 28, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented May 22, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 3ca1ac2 to 4bb2915 Compare May 22, 2024 08:33
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 4bb2915 to 5bd7602 Compare May 22, 2024 11:28
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 5bd7602 to 124de05 Compare May 22, 2024 12:05
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.16%. Comparing base (70cc2a9) to head (7f9ecce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   51.07%   50.16%   -0.91%     
==========================================
  Files          22       22              
  Lines         883      883              
  Branches      883      883              
==========================================
- Hits          451      443       -8     
- Misses        406      419      +13     
+ Partials       26       21       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 124de05 to 8b4e1a3 Compare May 22, 2024 12:18
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 8b4e1a3 to 3bd94fb Compare May 23, 2024 06:51
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 3bd94fb to 4a4ce84 Compare May 23, 2024 07:53
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 4a4ce84 to 66c33f7 Compare May 23, 2024 10:10
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch 2 times, most recently from f3db4f5 to ffca060 Compare May 26, 2024 08:24
@ArniStarkware ArniStarkware changed the base branch from arni/config/bin/dump_config to main May 26, 2024 08:24
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch 2 times, most recently from 405a4cd to 11f6fed Compare May 28, 2024 06:52
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 11f6fed to 828c4b2 Compare May 28, 2024 07:19
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @lev-starkware)


crates/mempool_node/src/config/config_test.rs line 19 at r1 (raw file):

    assert_matches!(component_config.validate().unwrap_err(), validation_errors => {
        let parse_err = ParsedValidationErrors::from(validation_errors);

Suggestion:

parsed_errors

@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 828c4b2 to 47dea97 Compare May 28, 2024 07:34
@ArniStarkware ArniStarkware force-pushed the arni/config/mempool_node/remove_redundent_tests branch from 47dea97 to 7f9ecce Compare May 28, 2024 07:36
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @lev-starkware)


crates/mempool_node/src/config/config_test.rs line 19 at r1 (raw file):

    assert_matches!(component_config.validate().unwrap_err(), validation_errors => {
        let parse_err = ParsedValidationErrors::from(validation_errors);

Done.

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

@ArniStarkware ArniStarkware marked this pull request as ready for review May 28, 2024 07:39
@ArniStarkware ArniStarkware merged commit fcdf7ae into main May 28, 2024
8 checks passed
@ArniStarkware ArniStarkware deleted the arni/config/mempool_node/remove_redundent_tests branch May 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants