-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove redundent mempool node config tests #165
test: remove redundent mempool node config tests #165
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
ea5c83b
to
d619c04
Compare
3ca1ac2
to
4bb2915
Compare
d619c04
to
3399d1a
Compare
4bb2915
to
5bd7602
Compare
3399d1a
to
29637fa
Compare
5bd7602
to
124de05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 51.07% 50.16% -0.91%
==========================================
Files 22 22
Lines 883 883
Branches 883 883
==========================================
- Hits 451 443 -8
- Misses 406 419 +13
+ Partials 26 21 -5 ☔ View full report in Codecov by Sentry. |
29637fa
to
0385976
Compare
124de05
to
8b4e1a3
Compare
0385976
to
a3b3603
Compare
8b4e1a3
to
3bd94fb
Compare
a3b3603
to
fed703c
Compare
3bd94fb
to
4a4ce84
Compare
fed703c
to
be349d7
Compare
4a4ce84
to
66c33f7
Compare
be349d7
to
028449e
Compare
f3db4f5
to
ffca060
Compare
405a4cd
to
11f6fed
Compare
11f6fed
to
828c4b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @lev-starkware)
crates/mempool_node/src/config/config_test.rs
line 19 at r1 (raw file):
assert_matches!(component_config.validate().unwrap_err(), validation_errors => { let parse_err = ParsedValidationErrors::from(validation_errors);
Suggestion:
parsed_errors
828c4b2
to
47dea97
Compare
47dea97
to
7f9ecce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @lev-starkware)
crates/mempool_node/src/config/config_test.rs
line 19 at r1 (raw file):
assert_matches!(component_config.validate().unwrap_err(), validation_errors => { let parse_err = ParsedValidationErrors::from(validation_errors);
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
This change is