test: remove redundent config tests #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
0ff40fa
to
31d798d
Compare
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
from
da2d051
to
67eba04
Compare
This was referenced May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 50.59% 49.88% -0.72%
==========================================
Files 21 21
Lines 840 840
Branches 840 840
==========================================
- Hits 425 419 -6
- Misses 394 398 +4
- Partials 21 23 +2 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
31d798d
to
9dbd6d0
Compare
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
from
67eba04
to
166d248
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
9dbd6d0
to
26e9410
Compare
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
from
166d248
to
43fc7d4
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
26e9410
to
c8a1e02
Compare
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
from
43fc7d4
to
594b159
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
c8a1e02
to
265e5f2
Compare
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
from
594b159
to
0a3b6c1
Compare
ArniStarkware
force-pushed
the
arni/config/mempool_node/update_config
branch
from
265e5f2
to
3042051
Compare
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
2 times, most recently
from
5925b99
to
13b61d5
Compare
ArniStarkware
changed the base branch from
arni/config/mempool_node/update_config
to
main
dafnamatsry
approved these changes
May 23, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
ArniStarkware
force-pushed
the
arni/config/test/remove_redundent_tests
branch
from
13b61d5
to
151ea3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is