feat: create dump_config for mempool node config

[ArniStarkware]

This change is 

[ArniStarkware]

• feat: create dump_config for mempool node config #164 👈
• test: remove redundent mempool node config tests #165
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.69%. Comparing base (41cf4a7) to head (26e115e).

Files	Patch %	Lines
crates/mempool_node/src/config/mod.rs	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #164       +/-   ##
===========================================
+ Coverage   49.40%   65.69%   +16.29%     
===========================================
  Files          24       25        +1     
  Lines         927      930        +3     
  Branches      927      930        +3     
===========================================
+ Hits          458      611      +153     
+ Misses        446      293      -153     
- Partials       23       26        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lev-starkware]

Reviewable status: 0 of 8 files reviewed, 3 unresolved discussions (waiting on @ArniStarkware, @dafnamatsry, and @Yael-Starkware)

---

crates/mempool_node/src/config/config_test.rs line 55 at r2 (raw file):

#[test]
fn test_dump_default_config() {

Only a question: Is this test checking that dump () is working OK?

---

crates/mempool_node/src/config/config_test.rs line 62 at r2 (raw file):

    insta::assert_json_snapshot!(dumped_default_config);

    assert!(default_config.validate().is_ok());

This line should come before "let dumped_default_config..." because if validation fails no need to check json snapshot.

Code quote:

assert!(default_config.validate().is_ok());

---

crates/mempool_node/src/config/config_test.rs line 78 at r2 (raw file):

    // Read the dumped config from the file.
    let from_code: serde_json::Value =
        serde_json::from_reader(File::open(tmp_file_path).unwrap()).unwrap();

I think that the next code should be enough:
look at " CODE SNIPPET (ii)"

Code quote (i):

    // Create a temporary file and dump the default config to it.
    let mut tmp_file_path = env::temp_dir();
    tmp_file_path.push("cfg.json");
    MempoolNodeConfig::default().dump_to_file(&vec![], tmp_file_path.to_str().unwrap()).unwrap();

    // Read the dumped config from the file.
    let from_code: serde_json::Value =
        serde_json::from_reader(File::open(tmp_file_path).unwrap()).unwrap();

Code snippet (ii):

    let from_code: serde_json::Value =
        serde_json::to_value(MempoolNodeConfig::default().dump()).unwrap();

[ArniStarkware]

Reviewable status: 0 of 8 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry, @lev-starkware, and @Yael-Starkware)

---

crates/mempool_node/src/config/config_test.rs line 55 at r2 (raw file):

Previously, lev-starkware wrote…

Only a question: Is this test checking that dump () is working OK?

Yes.

1. That the dump is working.
2. That the dumped value is consistent with the latest dumped value. If these values are inconsistent, the developer can review the changes and fix the snapshot by following the instructions presented by insta.

---

crates/mempool_node/src/config/config_test.rs line 62 at r2 (raw file):

Previously, lev-starkware wrote…

This line should come before "let dumped_default_config..." because if validation fails no need to check json snapshot.

Done.

---

crates/mempool_node/src/config/config_test.rs line 78 at r2 (raw file):

Previously, lev-starkware wrote…

I think that the next code should be enough:
look at " CODE SNIPPET (ii)"

Done.

[lev-starkware]

Reviewed 3 of 8 files at r1, 5 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)

[dafnamatsry]

Reviewed 3 of 8 files at r1, 5 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

[dafnamatsry]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)