Skip to content

Commit db608b5

Browse files
authored
Prepare for release v0.27.0 (#178)
ProductLine: Stash Release: v2023.03.13 Release-tracker: stashed/CHANGELOG#63 Signed-off-by: 1gtm <1gtm@appscode.com>
1 parent ee66407 commit db608b5

File tree

4 files changed

+23
-19
lines changed

4 files changed

+23
-19
lines changed

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ require (
2525
kmodules.xyz/objectstore-api v0.25.1-0.20221104003322-f0289b5b6ca2
2626
kmodules.xyz/offshoot-api v0.25.0
2727
kmodules.xyz/openshift v0.25.0
28-
stash.appscode.dev/apimachinery v0.26.0
29-
stash.appscode.dev/stash v0.26.0
28+
stash.appscode.dev/apimachinery v0.27.0
29+
stash.appscode.dev/stash v0.27.0
3030
)
3131

3232
require (

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,7 @@ sigs.k8s.io/yaml v1.1.0/go.mod h1:UJmg0vDUVViEyp3mgSv9WPwZCDxu4rQW1olrI1uml+o=
11001100
sigs.k8s.io/yaml v1.2.0/go.mod h1:yfXDCHCao9+ENCvLSE62v9VSji2MKu5jeNfTrofGhJc=
11011101
sigs.k8s.io/yaml v1.3.0 h1:a2VclLzOGrwOHDiV8EfBGhvjHvP46CtW5j6POvhYGGo=
11021102
sigs.k8s.io/yaml v1.3.0/go.mod h1:GeOyir5tyXNByN85N/dRIT9es5UQNerPYEKK56eTBm8=
1103-
stash.appscode.dev/apimachinery v0.26.0 h1:74H87DYEMFUO6vesQARIaiXG9N6wSyakTzSoJhBRJZ0=
1104-
stash.appscode.dev/apimachinery v0.26.0/go.mod h1:SLknx4Og4nrUflEJIQF5gjolXmetqXrpisoDlFNV2DI=
1105-
stash.appscode.dev/stash v0.26.0 h1:tiCvWnUbay8ZTvoymenDmPss8ziecSLB9BexUWU3gLQ=
1106-
stash.appscode.dev/stash v0.26.0/go.mod h1:A1qKswp8cXiS6vc/tRWtMj+I9F6UVZKb6SZ/PxU2zJM=
1103+
stash.appscode.dev/apimachinery v0.27.0 h1:3Ldo0ncYnsRT4VukSrawan0jWjc+D/nss1yAyDjWj8A=
1104+
stash.appscode.dev/apimachinery v0.27.0/go.mod h1:0bPMB3d0+3oR2hBqFeZyskBDEO5CyWnkHNV+Gp67bMA=
1105+
stash.appscode.dev/stash v0.27.0 h1:HesmCBHmmlwusftjwrduwYQC7KbQzSzaXCamcSFZtyA=
1106+
stash.appscode.dev/stash v0.27.0/go.mod h1:mI4KrWYan8tPvpjaZ6FbH2V5YoJWSIfe454hcqqggWE=

vendor/modules.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,7 @@ sigs.k8s.io/structured-merge-diff/v4/value
932932
# sigs.k8s.io/yaml v1.3.0
933933
## explicit; go 1.12
934934
sigs.k8s.io/yaml
935-
# stash.appscode.dev/apimachinery v0.26.0
935+
# stash.appscode.dev/apimachinery v0.27.0
936936
## explicit; go 1.18
937937
stash.appscode.dev/apimachinery/apis
938938
stash.appscode.dev/apimachinery/apis/repositories
@@ -961,7 +961,7 @@ stash.appscode.dev/apimachinery/pkg/docker
961961
stash.appscode.dev/apimachinery/pkg/invoker
962962
stash.appscode.dev/apimachinery/pkg/metrics
963963
stash.appscode.dev/apimachinery/pkg/restic
964-
# stash.appscode.dev/stash v0.26.0
964+
# stash.appscode.dev/stash v0.27.0
965965
## explicit; go 1.18
966966
stash.appscode.dev/stash/pkg/registry/snapshot
967967
stash.appscode.dev/stash/pkg/util

vendor/stash.appscode.dev/apimachinery/pkg/restic/commands.go

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,7 @@ func (w *ResticWrapper) backupFromStdin(options BackupOptions) ([]byte, error) {
149149
klog.Infoln("Backing up stdin data")
150150

151151
// first add StdinPipeCommands, then add restic command
152-
var commands []Command
153-
if len(options.StdinPipeCommands) != 0 {
154-
for i := range options.StdinPipeCommands {
155-
commands = append(commands, options.StdinPipeCommands[i])
156-
}
157-
}
152+
commands := options.StdinPipeCommands
158153

159154
args := []interface{}{"backup", "--stdin", "--quiet", "--json"}
160155
if options.StdinFileName != "" {
@@ -177,6 +172,19 @@ func (w *ResticWrapper) backupFromStdin(options BackupOptions) ([]byte, error) {
177172
func (w *ResticWrapper) cleanup(retentionPolicy v1alpha1.RetentionPolicy, host string) ([]byte, error) {
178173
klog.Infoln("Cleaning old snapshots according to retention policy")
179174

175+
out, err := w.tryCleanup(retentionPolicy, host)
176+
if err == nil || !strings.Contains(err.Error(), "unlock") {
177+
return out, err
178+
}
179+
// repo is locked, so unlock first
180+
klog.Warningln("repo found locked, so unlocking before pruning, err:", err.Error())
181+
if o2, e2 := w.unlock(); e2 != nil {
182+
return o2, e2
183+
}
184+
return w.tryCleanup(retentionPolicy, host)
185+
}
186+
187+
func (w *ResticWrapper) tryCleanup(retentionPolicy v1alpha1.RetentionPolicy, host string) ([]byte, error) {
180188
args := []interface{}{"forget", "--quiet", "--json"}
181189

182190
if host != "" {
@@ -304,11 +312,7 @@ func (w *ResticWrapper) dump(dumpOptions DumpOptions) ([]byte, error) {
304312
commands := []Command{
305313
{Name: ResticCMD, Args: args},
306314
}
307-
if len(dumpOptions.StdoutPipeCommands) != 0 {
308-
for i := range dumpOptions.StdoutPipeCommands {
309-
commands = append(commands, dumpOptions.StdoutPipeCommands[i])
310-
}
311-
}
315+
commands = append(commands, dumpOptions.StdoutPipeCommands...)
312316
return w.run(commands...)
313317
}
314318

0 commit comments

Comments
 (0)