Properly mark options fields. (#36)

* Properly mark options fields.

Signed-off-by: Tamal Saha <tamal@appscode.com>

* Run check once in ci pipeline

Signed-off-by: Tamal Saha <tamal@appscode.com>

* Add license header

Signed-off-by: Tamal Saha <tamal@appscode.com>

Author: tamalsaha

.github/workflows/ci.yml

@@ -12,9 +12,6 @@ jobs:
   build:
     name: Build
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        k8s: [v1.11.10, v1.12.10, v1.13.10, v1.14.6, v1.15.3, v1.16.3, v1.17.0]
     steps:
 
     - name: Set up Go 1.13
@@ -32,10 +29,23 @@ jobs:
         sudo apt-get install -y bzr
         make ci
 
+  kubernetes:
+    name: Kubernetes
+    runs-on: ubuntu-latest
+    needs: build
+    strategy:
+      matrix:
+        k8s: [v1.11.10, v1.12.10, v1.13.10, v1.14.6, v1.15.3, v1.16.3, v1.17.0]
+    steps:
+
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v1
+
     - name: Create Kubernetes ${{ matrix.k8s }} cluster
       id: kind
       uses: engineerd/setup-kind@v0.1.0
       with:
+        version: v0.7.0
         config: hack/kubernetes/kind.yaml
         image: kindest/node:${{ matrix.k8s }}
 
@@ -46,8 +56,6 @@ jobs:
         USERNAME: 1gtm
         REGISTRY_SECRET: regcred
       run: |
-        export KUBECONFIG="$(kind get kubeconfig-path)"
-        echo
         echo "waiting for nodes to be ready ..."
         kubectl wait --for=condition=Ready nodes --all --timeout=5m
         kubectl get nodes
@@ -56,7 +64,7 @@ jobs:
         echo
         echo "installing local-path provisioner ..."
         kubectl delete storageclass --all
-        kubectl apply -f https://github.com/rancher/local-path-provisioner/raw/v0.0.11/deploy/local-path-storage.yaml
+        kubectl apply -f https://github.com/rancher/local-path-provisioner/raw/v0.0.12/deploy/local-path-storage.yaml
         kubectl wait --for=condition=Ready pods -n local-path-storage --all --timeout=5m
         kubectl apply -f hack/kubernetes/storageclass/standard.yaml
         echo
@@ -65,6 +73,6 @@ jobs:
 
     - name: Test charts
       run: |
-        export KUBECONFIG="$(kind get kubeconfig-path)"
+        export KUBECONFIG="${HOME}/.kube/config"
         make ct
         kubectl delete crd -l app=stash

api/crds/bindata.go

@@ -649,10 +649,7 @@ spec:
                     serverKey:
                       type: string
                   required:
-                  - caCrt
                   - generate
-                  - serverCrt
-                  - serverKey
                   type: object
                 useKubeapiserverFqdnForAks:
                   type: boolean
@@ -707,17 +704,13 @@ spec:
                   properties:
                     namespace:
                       type: string
-                  required:
-                  - namespace
                   type: object
                 serviceMonitor:
                   properties:
                     labels:
                       additionalProperties:
                         type: string
                       type: object
-                  required:
-                  - labels
                   type: object
               required:
               - agent
@@ -747,8 +740,6 @@ spec:
               properties:
                 openshift:
                   type: boolean
-              required:
-              - openshift
               type: object
             pushgateway:
               properties:
@@ -774,7 +765,6 @@ spec:
                   type: string
               required:
               - create
-              - name
               type: object
             tolerations:
               description: If specified, the pod's tolerations.
@@ -817,16 +807,12 @@ spec:
                 type: object
               type: array
           required:
-          - additionalPodSecurityPolicies
           - apiserver
           - cleaner
           - enableAnalytics
-          - imagePullPolicy
           - imagePullSecrets
-          - logLevel
           - monitoring
           - operator
-          - platform
           - pushgateway
           - replicaCount
           - serviceAccount

api/crds/installer.stash.appscode.com_stashoperators.yaml

@@ -922,9 +922,6 @@
     },
     "dev.appscode.stash.installer.apis.installer.v1alpha1.Platform": {
       "type": "object",
-      "required": [
-        "openshift"
-      ],
       "properties": {
         "openshift": {
           "type": "boolean"
@@ -933,9 +930,6 @@
     },
     "dev.appscode.stash.installer.apis.installer.v1alpha1.PrometheusSpec": {
       "type": "object",
-      "required": [
-        "namespace"
-      ],
       "properties": {
         "namespace": {
           "type": "string"
@@ -945,8 +939,7 @@
     "dev.appscode.stash.installer.apis.installer.v1alpha1.ServiceAccountSpec": {
       "type": "object",
       "required": [
-        "create",
-        "name"
+        "create"
       ],
       "properties": {
         "create": {
@@ -959,9 +952,6 @@
     },
     "dev.appscode.stash.installer.apis.installer.v1alpha1.ServiceMonitorLabels": {
       "type": "object",
-      "required": [
-        "labels"
-      ],
       "properties": {
         "labels": {
           "type": "object",
@@ -974,10 +964,7 @@
     "dev.appscode.stash.installer.apis.installer.v1alpha1.ServingCerts": {
       "type": "object",
       "required": [
-        "generate",
-        "caCrt",
-        "serverCrt",
-        "serverKey"
+        "generate"
       ],
       "properties": {
         "caCrt": {
@@ -1059,15 +1046,11 @@
         "operator",
         "pushgateway",
         "cleaner",
-        "imagePullPolicy",
         "imagePullSecrets",
-        "logLevel",
         "serviceAccount",
         "apiserver",
         "enableAnalytics",
-        "monitoring",
-        "additionalPodSecurityPolicies",
-        "platform"
+        "monitoring"
       ],
       "properties": {
         "additionalPodSecurityPolicies": {