Extract json before unmarshal in mongodb commands (#2340) (#2355)

Extract json before unmarshal in mongodb commands (#2340)

Signed-off-by: sayedppqq <sayed@appscode.com>

Update CI runners image version

Signed-off-by: Anisur Rahman <anisur@appscode.com>

Author: anisurrahman75

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - name: Set up Go 1.24
         uses: actions/setup-go@v5

pkg/backup.go

@@ -722,7 +722,20 @@ func getPrimaryNSecondaryMember(mongoDSN string) (primary, secondary string, sec
 		"--eval", "JSON.stringify(rs.isMaster())",
 	}, mongoCreds...)
 	// even --quiet doesn't skip replicaset PrimaryConnection log. so take tha last line. issue tracker: https://jira.mongodb.org/browse/SERVER-27159
-	if err := sh.Command(MongoCMD, args...).Command("/usr/bin/tail", "-1").UnmarshalJSON(&v); err != nil {
+	output, err := sh.Command(MongoCMD, args...).Command("/usr/bin/tail", "-1").Output()
+	if err != nil {
+		klog.Errorf("Error while running isMaster : %s ; output : %s \n", err.Error(), output)
+		return "", "", secondaryMembers, err
+	}
+
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return "", "", secondaryMembers, err
+	}
+
+	err = json.Unmarshal(output, &v)
+	if err != nil {
+		klog.Errorf("Unmarshal error while running isMaster : %+v , output : %s \n", err.Error(), output)
 		return "", "", secondaryMembers, err
 	}
 
@@ -772,6 +785,11 @@ func disabelBalancer(mongosHost string) error {
 		return err
 	}
 
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return err
+	}
+
 	err = json.Unmarshal(output, &v)
 	if err != nil {
 		klog.Errorf("Unmarshal error while stopping balancer : %s ; output = %s \n", err.Error(), output)
@@ -825,6 +843,11 @@ func enableBalancer(mongosHost string) error {
 		}
 	}
 
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return err
+	}
+
 	err = json.Unmarshal(output, &v)
 	if err != nil {
 		klog.Errorf("Unmarshal error while enabling balancer : %+v , output : %s \n", err.Error(), output)

pkg/lock.go

@@ -47,6 +47,11 @@ func setupConfigServer(configSVRDSN, secondaryHost string) error {
 		return err
 	}
 
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return err
+	}
+
 	err = json.Unmarshal(output, &v)
 	if err != nil {
 		klog.Errorf("Unmarshal error while running findAndModify to setup configServer : %s \n", err.Error())
@@ -68,7 +73,18 @@ func setupConfigServer(configSVRDSN, secondaryHost string) error {
 			"--eval", "rs.secondaryOk(); db.BackupControl.find({ '_id' : 'BackupControlDocument' }).readConcern('majority');",
 		}, mongoCreds...)
 
-		if err := sh.Command(MongoCMD, args...).UnmarshalJSON(&v); err != nil {
+		output, err := sh.Command(MongoCMD, args...).Command("/usr/bin/tail", "-1").Output()
+		if err != nil {
+			return err
+		}
+
+		output, err = extractJSON(string(output))
+		if err != nil {
+			return err
+		}
+
+		err = json.Unmarshal(output, &v)
+		if err != nil {
 			return err
 		}
 
@@ -111,6 +127,11 @@ func lockSecondaryMember(mongohost string) error {
 		return err
 	}
 
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return err
+	}
+
 	err = json.Unmarshal(output, &v)
 	if err != nil {
 		klog.Errorf("Unmarshal error while running fsyncLock on secondary : %s \n", err.Error())
@@ -139,6 +160,12 @@ func checkIfSecondaryLockedAndSync(mongohost string) error {
 		klog.Errorf("Error while running currentOp on secondary : %s ; output : %s \n", err.Error(), output)
 		return err
 	}
+
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return err
+	}
+
 	err = json.Unmarshal(output, &x)
 	if err != nil {
 		klog.Errorf("Unmarshal error while running currentOp on secondary : %s \n", err.Error())
@@ -171,8 +198,18 @@ func waitForSecondarySync(mongohost string) error {
 			"--eval", "JSON.stringify(rs.status())",
 		}, mongoCreds...)
 
-		if err := sh.Command(MongoCMD, args...).Command("/usr/bin/tail", "-1").UnmarshalJSON(&status); err != nil {
-			klog.Errorf("Error while running status on secondary : %s ; output : %s \n", mongohost, err.Error())
+		output, err := sh.Command(MongoCMD, args...).Command("/usr/bin/tail", "-1").Output()
+		if err != nil {
+			return err
+		}
+
+		output, err = extractJSON(string(output))
+		if err != nil {
+			return err
+		}
+
+		err = json.Unmarshal(output, &status)
+		if err != nil {
 			return err
 		}
 
@@ -261,6 +298,12 @@ func unlockSecondaryMember(mongohost string) error {
 		klog.Errorf("Error while running fsyncUnlock on secondary : %s ; output : %s \n", err.Error(), output)
 		return err
 	}
+
+	output, err = extractJSON(string(output))
+	if err != nil {
+		return err
+	}
+
 	err = json.Unmarshal(output, &v)
 	if err != nil {
 		klog.Errorf("Unmarshal error while running fsyncUnlock on secondary : %s \n", err.Error())

pkg/utils.go

@@ -21,6 +21,7 @@ import (
 	"fmt"
 	"net/url"
 	"os/exec"
+	"regexp"
 	"strings"
 	"time"
 
@@ -195,3 +196,15 @@ func getBackupDB(mongoArgs string) string {
 	}
 	return ""
 }
+
+// extractJSON is needed due to ignore unnecessary character like /x1b from output before unmarshal
+func extractJSON(input string) ([]byte, error) {
+	// Regular expression to match JSON objects (assuming JSON starts with `{` and ends with `}`)
+	re := regexp.MustCompile(`\{.*\}`)
+	jsonPart := re.FindString(string(input))
+	if jsonPart == "" {
+		klog.Infoln("output from MongoDB:", input)
+		return nil, fmt.Errorf("no JSON part found in the output from MongoDB")
+	}
+	return []byte(jsonPart), nil
+}