Use workqueue for scheduler (#194)

tamalsaha · web-flow · commit e28c13f819b2 · 2017-10-09T21:44:37.000-07:00
diff --git a/schedule.go b/schedule.go
@@ -28,6 +28,7 @@ func NewCmdSchedule() *cobra.Command {
 			PushgatewayURL: "http://stash-operator.kube-system.svc:56789",
 			PodLabelsPath:  "/etc/stash/labels",
 			ResyncPeriod:   5 * time.Minute,
+			MaxNumRequeues: 5,
 		}
 	)
 
@@ -115,7 +116,12 @@ func NewCmdSchedule() *cobra.Command {
 			if err != nil {
 				log.Fatalf("Failed to setup scheduler: %s", err)
 			}
-			ctrl.RunAndHold()
+			stop := make(chan struct{})
+			defer close(stop)
+			go ctrl.Run(1, stop)
+
+			// Wait forever
+			select {}
 		},
 	}
 	cmd.Flags().StringVar(&masterURL, "master", masterURL, "The address of the Kubernetes API server (overrides any value in kubeconfig)")

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ func NewCmdSchedule() *cobra.Command {`
`28`	`28`	`PushgatewayURL: "http://stash-operator.kube-system.svc:56789",`
`29`	`29`	`PodLabelsPath: "/etc/stash/labels",`
`30`	`30`	`ResyncPeriod: 5 * time.Minute,`
	`31`	`+ MaxNumRequeues: 5,`
`31`	`32`	`}`
`32`	`33`	`)`
`33`	`34`
`@@ -115,7 +116,12 @@ func NewCmdSchedule() *cobra.Command {`
`115`	`116`	`if err != nil {`
`116`	`117`	`log.Fatalf("Failed to setup scheduler: %s", err)`
`117`	`118`	`}`
`118`		`- ctrl.RunAndHold()`
	`119`	`+ stop := make(chan struct{})`
	`120`	`+ defer close(stop)`
	`121`	`+ go ctrl.Run(1, stop)`
	`122`	`+`
	`123`	`+ // Wait forever`
	`124`	`+ select {}`
`119`	`125`	`},`
`120`	`126`	`}`
`121`	`127`	`cmd.Flags().StringVar(&masterURL, "master", masterURL, "The address of the Kubernetes API server (overrides any value in kubeconfig)")`