Skip to content

Commit a121b8c

Browse files
committed
Always set type meta for GenericResource
Signed-off-by: Tamal Saha <tamal@appscode.com>
1 parent 9300292 commit a121b8c

File tree

6 files changed

+15
-10
lines changed

6 files changed

+15
-10
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ require (
165165
k8s.io/component-base v0.21.1 // indirect
166166
k8s.io/kube-openapi v0.0.0-20210421082810-95288971da7e // indirect
167167
k8s.io/utils v0.0.0-20210802155522-efc7438f0176 // indirect
168-
kmodules.xyz/resource-metadata v0.9.0 // indirect
168+
kmodules.xyz/resource-metadata v0.9.1 // indirect
169169
kmodules.xyz/resource-metrics v0.0.8 // indirect
170170
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.15 // indirect
171171
sigs.k8s.io/cli-utils v0.26.1 // indirect

go.sum

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1257,8 +1257,9 @@ kmodules.xyz/openshift v0.0.0-20210618001443-f2507caa512f h1:V1lapZtGG7GntoUsOuE
12571257
kmodules.xyz/openshift v0.0.0-20210618001443-f2507caa512f/go.mod h1:8E5ckbd1KMNmR4hc7ScvmQnGfx1ULUUp+UTmoDdxRkc=
12581258
kmodules.xyz/prober v0.0.0-20210618020259-5836fb959027 h1:rtSPsruEkoBOLcbJkxMQjnPafpv8/vJnfWlTIj9yRBg=
12591259
kmodules.xyz/prober v0.0.0-20210618020259-5836fb959027/go.mod h1:H4NcvS1RQxeXtQONALbU6r9OT3Xa7cMhfamX/k9t9wo=
1260-
kmodules.xyz/resource-metadata v0.9.0 h1:kRY126ccnqHI3JTpZNocD2n+OY4zk1G8jczl7fp2BJk=
12611260
kmodules.xyz/resource-metadata v0.9.0/go.mod h1:GsaythrHLBLKhEy8/l+ioJC0mFmJmZR0FRXpkyxztt8=
1261+
kmodules.xyz/resource-metadata v0.9.1 h1:YQAeAnVKK7jULbV4HTcY2JJrtVsh9B64V6wn2FZEZm8=
1262+
kmodules.xyz/resource-metadata v0.9.1/go.mod h1:GsaythrHLBLKhEy8/l+ioJC0mFmJmZR0FRXpkyxztt8=
12621263
kmodules.xyz/resource-metrics v0.0.6/go.mod h1:M7rWuo2qh3BpHhogiEVPnvGY9Xx4Pfygqn1Rex8YbgM=
12631264
kmodules.xyz/resource-metrics v0.0.8 h1:4WHV7vKGfoxpZquu/Jowq4pgoMEithyMjFfJIg68Nq8=
12641265
kmodules.xyz/resource-metrics v0.0.8/go.mod h1:M7rWuo2qh3BpHhogiEVPnvGY9Xx4Pfygqn1Rex8YbgM=

vendor/kmodules.xyz/resource-metadata/apis/core/v1alpha1/generic_resource_helpers.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ func ToGenericResource(item client.Object, apiType *kmapi.ResourceID, cmeta *kma
7474
}
7575

7676
genres := GenericResource{
77-
// TypeMeta: metav1.TypeMeta{},
77+
TypeMeta: metav1.TypeMeta{
78+
APIVersion: GroupVersion.String(),
79+
Kind: ResourceKindGenericResource,
80+
},
7881
ObjectMeta: metav1.ObjectMeta{
7982
Name: GetGenericResourceName(item),
8083
GenerateName: item.GetGenerateName(),

vendor/kmodules.xyz/resource-metadata/apis/core/v1alpha1/generic_resource_types.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ type GenericResource struct {
4545
type GenericResourceSpec struct {
4646
Cluster kmapi.ClusterMetadata `json:"cluster,omitempty"`
4747
APIType kmapi.ResourceID `json:"apiType"`
48-
Name string `json:"name,omitempty"`
48+
Name string `json:"name"`
4949
Version string `json:"version,omitempty"`
5050
Replicas int64 `json:"replicas,omitempty"`
5151
RoleReplicas api.ReplicaList `json:"roleReplicas,omitempty"`
5252
Mode string `json:"mode,omitempty"`
53-
TotalResource core.ResourceRequirements `json:"totalResource"`
54-
AppResource core.ResourceRequirements `json:"appResource"`
53+
TotalResource core.ResourceRequirements `json:"totalResource,omitempty"`
54+
AppResource core.ResourceRequirements `json:"appResource,omitempty"`
5555
RoleResourceLimits map[api.PodRole]core.ResourceList `json:"roleResourceLimits,omitempty"`
5656
RoleResourceRequests map[api.PodRole]core.ResourceList `json:"roleResourceRequests,omitempty"`
5757
Status GenericResourceStatus `json:"status"`

vendor/kmodules.xyz/resource-metadata/apis/core/v1alpha1/openapi_generated.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1443,7 +1443,7 @@ kmodules.xyz/prober/probe
14431443
kmodules.xyz/prober/probe/exec
14441444
kmodules.xyz/prober/probe/http
14451445
kmodules.xyz/prober/probe/tcp
1446-
# kmodules.xyz/resource-metadata v0.9.0
1446+
# kmodules.xyz/resource-metadata v0.9.1
14471447
## explicit; go 1.17
14481448
kmodules.xyz/resource-metadata/apis/core/v1alpha1
14491449
# kmodules.xyz/resource-metrics v0.0.8

0 commit comments

Comments
 (0)