Skip to content

Commit ba1733e

Browse files
hossainemruztamalsaha
authored andcommitted
Don't check if target exist from BackupSession creating CronJob (#1028)
1 parent ddc65ce commit ba1733e

File tree

1 file changed

+0
-34
lines changed

1 file changed

+0
-34
lines changed

pkg/cmds/create_backupsession.go

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,15 @@ package cmds
1818

1919
import (
2020
"fmt"
21-
"strings"
2221
"time"
2322

2423
"stash.appscode.dev/stash/apis"
2524
api_v1beta1 "stash.appscode.dev/stash/apis/stash/v1beta1"
2625
cs "stash.appscode.dev/stash/client/clientset/versioned"
2726
v1beta1_util "stash.appscode.dev/stash/client/clientset/versioned/typed/stash/v1beta1/util"
28-
"stash.appscode.dev/stash/pkg/eventer"
29-
"stash.appscode.dev/stash/pkg/util"
3027

3128
"github.com/appscode/go/log"
3229
"github.com/spf13/cobra"
33-
core "k8s.io/api/core/v1"
3430
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3531
"k8s.io/client-go/kubernetes"
3632
"k8s.io/client-go/tools/clientcmd"
@@ -106,24 +102,6 @@ func (opt *options) createBackupSession() error {
106102
OwnerReferences: []metav1.OwnerReference{},
107103
}
108104

109-
wc := util.WorkloadClients{
110-
KubeClient: opt.k8sClient,
111-
StashClient: opt.stashClient,
112-
AppCatalogClient: opt.appcatalogClient,
113-
OcClient: opt.ocClient,
114-
}
115-
116-
for _, targetInfo := range invoker.TargetsInfo {
117-
if targetInfo.Target != nil && !wc.IsTargetExist(targetInfo.Target.Ref, opt.namespace) {
118-
msg := fmt.Sprintf("Skipping creating BackupSession. Reason: Target workload %s/%s does not exist.",
119-
strings.ToLower(targetInfo.Target.Ref.Kind), targetInfo.Target.Ref.Name)
120-
log.Infoln(msg)
121-
122-
// write event to backup invoker denoting that backup session has been skipped
123-
return writeBackupSessionSkippedEvent(opt.k8sClient, invoker.ObjectRef, msg)
124-
}
125-
}
126-
127105
// create BackupSession
128106
_, _, err = v1beta1_util.CreateOrPatchBackupSession(opt.stashClient.StashV1beta1(), bsMeta, func(in *api_v1beta1.BackupSession) *api_v1beta1.BackupSession {
129107
// Set BackupConfiguration as BackupSession Owner
@@ -143,15 +121,3 @@ func (opt *options) createBackupSession() error {
143121
})
144122
return err
145123
}
146-
147-
func writeBackupSessionSkippedEvent(kubeClient kubernetes.Interface, invokerRef *core.ObjectReference, msg string) error {
148-
_, err := eventer.CreateEvent(
149-
kubeClient,
150-
eventer.EventSourceBackupTriggeringCronJob,
151-
invokerRef,
152-
core.EventTypeNormal,
153-
eventer.EventReasonBackupSkipped,
154-
msg,
155-
)
156-
return err
157-
}

0 commit comments

Comments
 (0)