Use Go 1.23 (#1574)

* Use Go 1.23

/cherry-pick

Signed-off-by: 1gtm <1gtm@appscode.com>

* Fix linter issue

Signed-off-by: Md. Ishtiaq Islam <ishtiaq@appscode.com>

---------

Signed-off-by: 1gtm <1gtm@appscode.com>
Signed-off-by: Md. Ishtiaq Islam <ishtiaq@appscode.com>
Co-authored-by: Md. Ishtiaq Islam <ishtiaq@appscode.com>

Author: 1gtm

.github/workflows/ci.yml

@@ -17,12 +17,12 @@ concurrency:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
-      - name: Set up Go 1.22
+      - name: Set up Go 1.23
         uses: actions/setup-go@v1
         with:
-          go-version: '1.22'
+          go-version: '1.23'
         id: go
 
       - name: Check out code into the Go module directory

.github/workflows/e2e.yml

@@ -18,7 +18,7 @@ concurrency:
 jobs:
   build:
     if: contains(github.event.issue.html_url, '/pull/') && startsWith(github.event.comment.body, '/ok-to-test')
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v1
 
@@ -52,7 +52,7 @@ jobs:
           make push
 
   config:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     needs: build
     outputs:
       matrix: ${{ steps.set-matrix.outputs.matrix }}
@@ -82,7 +82,7 @@ jobs:
   kubernetes:
     name: Kubernetes
     needs: config
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     strategy:
       matrix: ${{ fromJson(needs.config.outputs.matrix) }}
     steps:

.github/workflows/release-tracker.yml

@@ -12,7 +12,7 @@ concurrency:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v1

.github/workflows/release.yml

@@ -14,7 +14,7 @@ concurrency:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v1
 

.github/workflows/update-docs.yml

@@ -14,12 +14,12 @@ concurrency:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
-      - name: Set up Go 1.22
+      - name: Set up Go 1.23
         uses: actions/setup-go@v1
         with:
-          go-version: '1.22'
+          go-version: '1.23'
         id: go
 
       - uses: actions/checkout@v1

Makefile

@@ -72,7 +72,7 @@ TAG              := $(VERSION)_$(OS)_$(ARCH)
 TAG_PROD         := $(TAG)
 TAG_DBG          := $(VERSION)-dbg_$(OS)_$(ARCH)
 
-GO_VERSION       ?= 1.22
+GO_VERSION       ?= 1.23
 BUILD_IMAGE      ?= ghcr.io/appscode/golang-dev:$(GO_VERSION)
 TEST_IMAGE       ?= ghcr.io/appscode/golang-dev:$(GO_VERSION)-stash
 

pkg/cmds/create_volumesnapshot.go

@@ -231,8 +231,7 @@ func (opt *VSoption) createVolumeSnapshot(bsMeta metav1.ObjectMeta, inv invoker.
 		}
 		err := prober.RunProbe(opt.config, targetInfo.Hooks.PostBackup.Handler, podName, opt.namespace)
 		if err != nil {
-			return nil, fmt.Errorf(err.Error() + "Warning: The actual backup process may be succeeded." +
-				"Hence, the backup snapshots might be present in the backend even if the overall BackupSession phase is 'Failed'")
+			return nil, fmt.Errorf("%w Warning: The actual backup process may be succeeded. Hence, the backup snapshots might be present in the backend even if the overall BackupSession phase is 'Failed'", err)
 		}
 		backupOutput.BackupTargetStatus.Conditions = append(backupOutput.BackupTargetStatus.Conditions, kmapi.Condition{
 			Type:               api_v1beta1.PostBackupHookExecutionSucceeded,

pkg/cmds/restore_volumesnapshot.go

@@ -254,8 +254,7 @@ func (opt *VSoption) restoreVolumeSnapshot(targetInfo invoker.RestoreTargetInfo)
 		}
 		err := prober.RunProbe(opt.config, targetInfo.Hooks.PostRestore.Handler, podName, opt.namespace)
 		if err != nil {
-			return nil, fmt.Errorf(err.Error() + "Warning: The actual restore process may be succeeded." +
-				"Hence, the restored data might be present in the target even if the overall RestoreSession phase is 'Failed'")
+			return nil, fmt.Errorf("%w Warning: The actual restore process may be succeeded. Hence, the restored data might be present in the target even if the overall RestoreSession phase is 'Failed'", err)
 		}
 		klog.Infoln("postRestore hooks has been executed successfully")
 	}

test/e2e/framework/minio_server.go

@@ -108,7 +108,7 @@ func (f *Framework) SecretForMinioServer(ips []net.IP) core.Secret {
 
 	return core.Secret{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      fmt.Sprintf(MinioServerSecret + f.namespace),
+			Name:      MinioServerSecret + f.namespace,
 			Namespace: f.namespace,
 		},
 		Data: map[string][]byte{