Update client-go to kubernetes-1.16.3 (#987)

* Update client-go to kubernetes-1.16.3

Signed-off-by: Tamal Saha <tamal@appscode.com>

* Fix OwnerReference + Refactor auto-backup code

Co-authored-by: Md. Emruz Hossain <hossainemruz@gmail.com>

Author: tamalsaha

.github/workflows/ci.yml

@@ -14,9 +14,15 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        k8s: [v1.12.10, v1.14.6, v1.16.2]
+        k8s: [v1.12.10, v1.14.6, v1.16.3, v1.17.0]
     steps:
 
+    - name: Set up Go 1.13
+      uses: actions/setup-go@v1
+      with:
+        go-version: 1.13
+      id: go
+
     - name: Check out code into the Go module directory
       uses: actions/checkout@v1
 
@@ -48,6 +54,7 @@ jobs:
       id: kind
       uses: engineerd/setup-kind@v0.1.0
       with:
+        version: v0.6.0
         config: hack/kubernetes/kind.yaml
         image: kindest/node:${{ matrix.k8s }}
 
@@ -58,8 +65,6 @@ jobs:
         USERNAME: 1gtm
         REGISTRY_SECRET: regcred
       run: |
-        export KUBECONFIG="$(kind get kubeconfig-path)"
-        echo
         echo "waiting for nodes to be ready ..."
         kubectl wait --for=condition=Ready nodes --all --timeout=5m
         kubectl get nodes
@@ -90,7 +95,6 @@ jobs:
         TEST_CREDENTIALS: ${{ secrets.TEST_CREDENTIALS }}
         GOOGLE_SERVICE_ACCOUNT_JSON_KEY: ${{ secrets.GOOGLE_SERVICE_ACCOUNT_JSON_KEY }}
       run: |
-        export KUBECONFIG="$(kind get kubeconfig-path)"
         echo "preparing test credentials"
         mkdir -p hack/config
         echo -n "$TEST_CREDENTIALS" > hack/config/.env

Makefile

@@ -21,8 +21,8 @@ BIN      := stash
 COMPRESS ?=no
 
 # Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
-CRD_OPTIONS          ?= "crd:trivialVersions=true"
-CODE_GENERATOR_IMAGE ?= appscode/gengo:release-1.14
+CRD_OPTIONS          ?= "crd:trivialVersions=true,preserveUnknownFields=false"
+CODE_GENERATOR_IMAGE ?= appscode/gengo:release-1.16
 API_GROUPS           ?= repositories:v1alpha1 stash:v1alpha1 stash:v1beta1
 
 # Where to push the docker image.
@@ -76,7 +76,7 @@ TAG              := $(VERSION)_$(OS)_$(ARCH)
 TAG_PROD         := $(TAG)
 TAG_DBG          := $(VERSION)-dbg_$(OS)_$(ARCH)
 
-GO_VERSION       ?= 1.12.12
+GO_VERSION       ?= 1.13.5
 BUILD_IMAGE      ?= appscode/golang-dev:$(GO_VERSION)
 TEST_IMAGE       ?= appscode/golang-dev:$(GO_VERSION)-stash
 
@@ -187,6 +187,8 @@ openapi: $(addprefix openapi-, $(subst :,_, $(API_GROUPS)))
 		-w $(DOCKER_REPO_ROOT)                           \
 		--env HTTP_PROXY=$(HTTP_PROXY)                   \
 		--env HTTPS_PROXY=$(HTTPS_PROXY)                 \
+		--env GO111MODULE=on                             \
+		--env GOFLAGS="-mod=vendor"                      \
 		$(BUILD_IMAGE)                                   \
 		go run hack/gencrd/main.go
 

api/api-rules/violation_exceptions.list

@@ -29,6 +29,7 @@ spec:
     listKind: BackupSessionList
     plural: backupsessions
     singular: backupsession
+  preserveUnknownFields: false
   scope: Namespaced
   subresources:
     status: {}
@@ -38,12 +39,12 @@ spec:
         apiVersion:
           description: 'APIVersion defines the versioned schema of this representation
             of an object. Servers should convert recognized schemas to the latest
-            internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources'
+            internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
           type: string
         kind:
           description: 'Kind is a string value representing the REST resource this
             object represents. Servers may infer this from the endpoint the client
-            submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds'
+            submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
           type: string
         metadata:
           type: object

api/crds/bindata.go

@@ -21,6 +21,7 @@ spec:
     shortNames:
     - fn
     singular: function
+  preserveUnknownFields: false
   scope: Cluster
   subresources: {}
   validation:
@@ -29,12 +30,12 @@ spec:
         apiVersion:
           description: 'APIVersion defines the versioned schema of this representation
             of an object. Servers should convert recognized schemas to the latest
-            internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources'
+            internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
           type: string
         kind:
           description: 'Kind is a string value representing the REST resource this
             object represents. Servers may infer this from the endpoint the client
-            submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds'
+            submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
           type: string
         metadata:
           type: object
@@ -150,7 +151,7 @@ spec:
                                   uid?'
                                 type: string
                               optional:
-                                description: Specify whether the ConfigMap or it's
+                                description: Specify whether the ConfigMap or its
                                   key must be defined
                                 type: boolean
                             required:
@@ -206,7 +207,7 @@ spec:
                                   uid?'
                                 type: string
                               optional:
-                                description: Specify whether the Secret or it's key
+                                description: Specify whether the Secret or its key
                                   must be defined
                                 type: boolean
                             required:
@@ -364,7 +365,7 @@ spec:
                     preStop:
                       description: 'PreStop is called immediately before a container
                         is terminated due to an API request or management event such
-                        as liveness probe failure, preemption, resource contention,
+                        as liveness/startup probe failure, preemption, resource contention,
                         etc. The handler is not called if the container crashes or
                         exits. The reason for termination is passed to the handler.
                         The Pod''s termination grace period countdown begins before
@@ -540,7 +541,7 @@ spec:
                     successThreshold:
                       description: Minimum consecutive successes for the probe to
                         be considered successful after having failed. Defaults to
-                        1. Must be 1 for liveness. Minimum value is 1.
+                        1. Must be 1 for liveness and startup. Minimum value is 1.
                       format: int32
                       type: integer
                     tcpSocket:
@@ -662,7 +663,7 @@ spec:
                     successThreshold:
                       description: Minimum consecutive successes for the probe to
                         be considered successful after having failed. Defaults to
-                        1. Must be 1 for liveness. Minimum value is 1.
+                        1. Must be 1 for liveness and startup. Minimum value is 1.
                       format: int32
                       type: integer
                     tcpSocket:
@@ -805,6 +806,36 @@ spec:
                             the container.
                           type: string
                       type: object
+                    windowsOptions:
+                      description: The Windows specific settings applied to all containers.
+                        If unspecified, the options from the PodSecurityContext will
+                        be used. If set in both SecurityContext and PodSecurityContext,
+                        the value specified in SecurityContext takes precedence.
+                      properties:
+                        gmsaCredentialSpec:
+                          description: GMSACredentialSpec is where the GMSA admission
+                            webhook (https://github.com/kubernetes-sigs/windows-gmsa)
+                            inlines the contents of the GMSA credential spec named
+                            by the GMSACredentialSpecName field. This field is alpha-level
+                            and is only honored by servers that enable the WindowsGMSA
+                            feature flag.
+                          type: string
+                        gmsaCredentialSpecName:
+                          description: GMSACredentialSpecName is the name of the GMSA
+                            credential spec to use. This field is alpha-level and
+                            is only honored by servers that enable the WindowsGMSA
+                            feature flag.
+                          type: string
+                        runAsUserName:
+                          description: The UserName in Windows to run the entrypoint
+                            of the container process. Defaults to the user specified
+                            in image metadata if unspecified. May also be set in PodSecurityContext.
+                            If set in both SecurityContext and PodSecurityContext,
+                            the value specified in SecurityContext takes precedence.
+                            This field is alpha-level and it is only honored by servers
+                            that enable the WindowsRunAsUserName feature flag.
+                          type: string
+                      type: object
                   type: object
               type: object
             volumeDevices:
@@ -859,7 +890,7 @@ spec:
                       volume should be mounted. Behaves similarly to SubPath but environment
                       variable references $(VAR_NAME) are expanded using the container's
                       environment. Defaults to "" (volume's root). SubPathExpr and
-                      SubPath are mutually exclusive. This field is alpha in 1.14.
+                      SubPath are mutually exclusive. This field is beta in 1.15.
                     type: string
                 required:
                 - mountPath