Skip to content

Commit db709fd

Browse files
tahsinrahmantamalsaha
authored andcommitted
Verify generated files are up to date (#925)
1 parent 5fb5419 commit db709fd

File tree

1 file changed

+23
-6
lines changed

1 file changed

+23
-6
lines changed

Makefile

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ DOCKER_REPO_ROOT := /go/src/$(GO_PKG)/$(REPO)
141141
.PHONY: clientset
142142
clientset:
143143
# for EAS types
144-
@docker run --rm -ti \
144+
@docker run --rm \
145145
-u $$(id -u):$$(id -g) \
146146
-v /tmp:/.cache \
147147
-v $$(pwd):$(DOCKER_REPO_ROOT) \
@@ -158,7 +158,7 @@ clientset:
158158
--go-header-file "./hack/boilerplate.go.txt"
159159

160160
# for both CRD and EAS types
161-
@docker run --rm -ti \
161+
@docker run --rm \
162162
-u $$(id -u):$$(id -g) \
163163
-v /tmp:/.cache \
164164
-v $$(pwd):$(DOCKER_REPO_ROOT) \
@@ -177,7 +177,7 @@ clientset:
177177
.PHONY: openapi
178178
openapi: $(addprefix openapi-, $(subst :,_, $(API_GROUPS)))
179179
@echo "Generating api/openapi-spec/swagger.json"
180-
@docker run --rm -ti \
180+
@docker run --rm \
181181
-u $$(id -u):$$(id -g) \
182182
-v /tmp:/.cache \
183183
-v $$(pwd):$(DOCKER_REPO_ROOT) \
@@ -190,7 +190,7 @@ openapi: $(addprefix openapi-, $(subst :,_, $(API_GROUPS)))
190190
openapi-%:
191191
@echo "Generating openapi schema for $(subst _,/,$*)"
192192
@mkdir -p api/api-rules
193-
@docker run --rm -ti \
193+
@docker run --rm \
194194
-u $$(id -u):$$(id -g) \
195195
-v /tmp:/.cache \
196196
-v $$(pwd):$(DOCKER_REPO_ROOT) \
@@ -209,7 +209,7 @@ openapi-%:
209209
.PHONY: gen-crds
210210
gen-crds:
211211
@echo "Generating CRD manifests"
212-
@docker run --rm -ti \
212+
@docker run --rm \
213213
-u $$(id -u):$$(id -g) \
214214
-v /tmp:/.cache \
215215
-v $$(pwd):$(DOCKER_REPO_ROOT) \
@@ -452,8 +452,25 @@ purge:
452452
.PHONY: dev
453453
dev: gen fmt push
454454

455+
.PHONY: verify
456+
verify: verify-modules verify-gen
457+
458+
.PHONY: verify-modules
459+
verify-modules:
460+
GO111MODULE=on go mod tidy
461+
GO111MODULE=on go mod vendor
462+
@if !(git diff --quiet HEAD); then \
463+
echo "go module files are out of date"; exit 1; \
464+
fi
465+
466+
.PHONY: verify-gen
467+
verify-gen: gen
468+
@if !(git diff --quiet HEAD); then \
469+
echo "generated files are out of date, run make gen"; exit 1; \
470+
fi
471+
455472
.PHONY: ci
456-
ci: lint test build #cover
473+
ci: verify lint test build #cover
457474

458475
.PHONY: qa
459476
qa:

0 commit comments

Comments
 (0)