Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waveform overwrites another when 2 wavforms are on screen. #135

Open
robertglatzel opened this issue May 6, 2023 · 9 comments
Open

waveform overwrites another when 2 wavforms are on screen. #135

robertglatzel opened this issue May 6, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@robertglatzel
Copy link

Hello, I've noticed an issue (or perhaps I'm missing something here) that when i have 2 waveform elements loaded, one's canvas will overwrite the other.

The workflow is:
I record audio > it is then loaded into a waveform.
I also load a song into a waveform.

When I click on the song waveform, it retains its waveform.
When I click on the recording waveform, the song waveform is drawn over it.

My guess is that the canvas is being overwritten and is not unique to each instance.

Am i doing something wrong here, or is my assumption correct?

Thanks!

Screenshot 2023-05-06 at 12 33 39 PM

Screenshot 2023-05-06 at 12 33 47 PM

@staskobzar
Copy link
Owner

Hello,
No, it is unique per instance. Make sure you are not referencing to the same canvas element from different plugin instances.
Probably I can say more if you see the code that generates those waveforms.

@robertglatzel
Copy link
Author

robertglatzel commented May 6, 2023 via email

@staskobzar
Copy link
Owner

Hi Robert,
Sure, send me a screenshot or code so that I can re-create this bug to start fixing it.

@robertglatzel
Copy link
Author

robertglatzel commented May 8, 2023 via email

@staskobzar
Copy link
Owner

my email is staskobzar@gmail.com

@staskobzar
Copy link
Owner

Hey Robert,
Yes, there is a bug with multiple Waveform on the same page. I was able to re-create it.
Thanks for reporting it and for the details. I will need to fix it.
Will posts updates here.
Have a good day!

staskobzar added a commit that referenced this issue May 9, 2023
staskobzar added a commit that referenced this issue May 9, 2023
@staskobzar
Copy link
Owner

Hey Robert,
New version 3.0.5 with the fix is released. Please update and try

@robertglatzel
Copy link
Author

robertglatzel commented May 9, 2023 via email

@staskobzar
Copy link
Owner

@robertglatzel It is already released. You can try it

@staskobzar staskobzar added the bug Something isn't working label May 10, 2023
@staskobzar staskobzar self-assigned this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants