Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix directory separator in Templates fieldtype on Windows #9483

Merged
merged 9 commits into from
Feb 9, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Feb 8, 2024

This pull request fixes an issue where the directory separator is wrong when using the Templates fieldtype on Windows.

I tried to fix this issue a few months ago in #9197 but seems like it's still an issue. I've added a test to ensure it's actually fixed since we don't use Windows for development.

Fixes #9458.

@duncanmcclean duncanmcclean marked this pull request as ready for review February 8, 2024 17:23
@jasonvarga jasonvarga merged commit 461f8c7 into 4.x Feb 9, 2024
35 checks passed
@jasonvarga jasonvarga deleted the fix/template-directory-separator-windows branch February 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory seperator wrong on windows
2 participants