Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Fix directory separator in Templates fieldtype on Windows #9483

Merged
merged 9 commits into from
Feb 9, 2024
Merged

[4.x] Fix directory separator in Templates fieldtype on Windows #9483

merged 9 commits into from
Feb 9, 2024

Commits on Feb 8, 2024

  1. Actually run tests on Windows in GitHub Actions 

    Can be reverted after #9482 is merged.

Can be reverted after #9482 is merged.
    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ac806b8 View commit details
    Browse the repository at this point in the history

  2. We only need the index

    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6768351 View commit details
    Browse the repository at this point in the history

  3. Add test for templates fieldtype

    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d812514 View commit details
    Browse the repository at this point in the history

  4. Ensure templates get ordered

    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3e0d7ac View commit details
    Browse the repository at this point in the history

  5. Replace windows directory separator with expected separator

    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e954bec View commit details
    Browse the repository at this point in the history

  6. Run both commands in the same step

    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    05067c1 View commit details
    Browse the repository at this point in the history

  7. Revert "Run both commands in the same step" 

    This reverts commit 05067c1.
    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    89212b6 View commit details
    Browse the repository at this point in the history

  8. Revert "Actually run tests on Windows in GitHub Actions" 

    This reverts commit ac806b8.
    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    78512c0 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/4.x' into fix/template-directory… 

    …-separator-windows
    @duncanmcclean
    duncanmcclean committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    961ed8d View commit details
    Browse the repository at this point in the history