-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internationalization errors on tests #8
Open
nikosmichas
wants to merge
7
commits into
state-machines:master
Choose a base branch
from
nikosmichas:fix_internationalization_errors_on_tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix internationalization errors on tests #8
nikosmichas
wants to merge
7
commits into
state-machines:master
from
nikosmichas:fix_internationalization_errors_on_tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The translations cannot be loaded if the path is not there leading to 4 failing tests
Can you add all the other gemfile ? |
Sure, added for |
Yes 5.1. |
You should drop old version of ruby to pass the whole matrix. You can drop tests in any unsupported versions of rails too. |
nikosmichas
force-pushed
the
fix_internationalization_errors_on_tests
branch
from
July 2, 2020 06:44
61476e8
to
58e7f8b
Compare
nikosmichas
force-pushed
the
fix_internationalization_errors_on_tests
branch
from
July 2, 2020 06:51
58e7f8b
to
097f885
Compare
Hello @seuros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are failing currently
All those are translations related.
Adding the
StateMachines::Integrations::Mongoid.locale_path
toI18n.load_path
allows the tests to run without failure.