fix: correct path on Windows to create and delete typegen file #41
Conversation
client/src/typegenService.ts
Outdated
|
|
||
| const newUri = vscode.Uri.file( | ||
| uri.replace(/\.([j,t])sx?$/, ".typegen.ts"), | ||
| const pathFromUri = vscode.Uri.parse(uri, true).path.slice(1); |
There was a problem hiding this comment.
Could you tell us how does your uri exactly looks like? this could help us reviewing this change and comparing with unix-style paths
There was a problem hiding this comment.
You can see the different variables in this image :
There was a problem hiding this comment.
When I remove the slice(1) from line 52, it throws an error when trying to write the file. C: is added somehow.
There was a problem hiding this comment.
I tried my changes on a debian OS. It didn't work because I was removing the leading slash. I added a check to remove the leading slash only on Windows. I don't know if there is a cleaner way to handle this but now it works for both Windows and Unix
|
@batnyu Tested this locally on Mac OS, and it works! Since this is a critical fix for Windows, let's merge it and test on Unix later. |
Hello Matt,
Thanks for your work on XState, it's amazing and inspiring!
On Windows, the typegen file is not generated. I followed the lead you wrote in the issue #40.
I fixed the issue on Windows. Unfortunately, I don't have a Mac, so I was unable to test on macOs. But maybe, it can help you.
I used
vscode.Uri.parseto extract the path from the URI. But the result is prefixed with a slash that causedfs.writeFileto prefix the path with "C:". So I removed this slash withslice(1)and it works! (at least on Windows).Thanks!