Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type inferring mistakes for State #1176

Merged
merged 3 commits into from
May 4, 2020
Merged

Fix type inferring mistakes for State #1176

merged 3 commits into from
May 4, 2020

Conversation

itfarrier
Copy link

@itfarrier itfarrier commented May 4, 2020

I have in my project something like this:
Screen Shot 2020-05-04 at 16 11 24

With my fixes I have:
Screen Shot 2020-05-04 at 16 11 37

P. S. I have 14 failed tests (cause error TS2307: Cannot find module 'xstate'. error) even in master branch without changes. I have no errors while setting up the project through yarn. Could you please help me with setting up the project?

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2020

🦋 Changeset is good to go

Latest commit: a10d604

We got this.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a10d604:

Sandbox Source
practical-mcclintock-15663 Configuration
beautiful-leaf-72fse Configuration

@Andarist
Copy link
Member

Andarist commented May 4, 2020

Run yarn dev to get most out of the current build+test setup

@itfarrier
Copy link
Author

itfarrier commented May 4, 2020

Run yarn dev to get most out of the current build+test setup

Thank you for your help and fast response. No errors after it.

Test Suites: 60 passed, 60 total
Tests:       12 skipped, 866 passed, 878 total
Snapshots:   20 passed, 20 total
Time:        26.16s
Ran all test suites in 9 projects.

@davidkpiano davidkpiano self-requested a review May 4, 2020 13:34
@davidkpiano davidkpiano merged commit f159973 into statelyai:master May 4, 2020
@github-actions github-actions bot mentioned this pull request May 4, 2020
@itfarrier itfarrier deleted the fixStateTypeInferring branch May 4, 2020 16:45
@github-actions github-actions bot mentioned this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants