Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with updating options in React's effect #2587

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

Andarist
Copy link
Member

fixes #2586 (a regression caused by #2241)

i will add a changeset and tests in a few hours

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2021

🦋 Changeset detected

Latest commit: 5aaa844

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@xstate/react Patch
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@mattpocock mattpocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense why this would break!

@Andarist Andarist merged commit efc8e25 into main Aug 31, 2021
@Andarist Andarist deleted the andarist/fix-options-syncing-in-react branch August 31, 2021 12:46
@github-actions github-actions bot mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@xstate/react] v1.6.0 breaks merging of service definitions
3 participants