Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with functions used as inline actions not always receiving the correct arguments when used with preserveActionOrder #2649

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

Andarist
Copy link
Member

fixes #2643

Sadly, I've noticed this back in July: #2430 (comment) and even implemented this test back then: c49e058 but I've used that as an argument against that linked PR while not realizing that this is already broken on the main branch 😢

…ving the correct arguments when used with `preserveActionOrder`
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2021

🦋 Changeset detected

Latest commit: f61c96c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@davidkpiano davidkpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the mutation! 🙈

@Andarist Andarist merged commit ad61100 into main Sep 15, 2021
@Andarist Andarist deleted the andarist/fix-2643 branch September 15, 2021 05:16
@github-actions github-actions bot mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected results with preserveActionOrder
2 participants