Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sendTo to the rest of the exported actions #2925

Merged

Conversation

devanfarrell
Copy link
Contributor

Resolves issue #2923

Contributing guidelines requested a test but none was added due to there not being an existing pattern to cleanly do so.

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2022

🦋 Changeset detected

Latest commit: 12b95a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Jan 7, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@Andarist
Copy link
Member

Andarist commented Jan 7, 2022

Ye, let's skip over adding a test for this - it's not worth it. Could you add a changeset though?

@devanfarrell
Copy link
Contributor Author

@Andarist The changeset tool thinks this is a major version bump. Feels like it should be a patch but I don't want to mess with the flow of anything without some direction.

@Andarist
Copy link
Member

Andarist commented Jan 8, 2022

@Andarist The changeset tool thinks this is a major version bump. Feels like it should be a patch but I don't want to mess with the flow of anything without some direction.

You had to accidentally accept a major bump type when creating a changeset file through the CLI. The CLI itself is just a convenience tool and changeset files can be created/modified manually so I've just patched this here:
f8d8957

Thank you for your contribution!

@davidkpiano davidkpiano merged commit 6711d51 into statelyai:main Jan 8, 2022
@github-actions github-actions bot mentioned this pull request Jan 8, 2022
@devanfarrell devanfarrell deleted the export-sendTo-from-actions-object branch January 9, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants