Added t() to allow for simpler use of schema #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3252065 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
davidkpiano
reviewed
Jan 25, 2022
| @@ -1,3 +1,4 @@ | |||
| export function createSchema<T>(schema?: any): T { | |||
There was a problem hiding this comment.
Suggested change
| export function createSchema<T>(schema?: any): T { | |
| /** | |
| * @deprecated Use `t<SomeType>()` instead. | |
| **/ | |
| export function createSchema<T>(schema?: any): T { |
There was a problem hiding this comment.
Will this work as intended? Since t is an alias it might rely on the createSchema TSDocs
There was a problem hiding this comment.
Maybe move the function definition to t instead?
This is nit-level but useful for folks using createSchema; can be done in a separate PR by the way
davidkpiano
approved these changes
Jan 25, 2022
davidkpiano
deleted the
matt/added-t-to-allow-for-simpler-use-of-schema
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.