Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @ts-ignore to a JSDoc comment so it gets preserved after compilation #2981

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

Andarist
Copy link
Member

fixes #2979

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2022

🦋 Changeset detected

Latest commit: b33af70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Jan 28, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b33af70:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@Andarist Andarist merged commit edf60d6 into main Jan 28, 2022
@Andarist Andarist deleted the andarist/fix-2979 branch January 28, 2022 13:19
@github-actions github-actions bot mentioned this pull request Jan 28, 2022
@mlegait
Copy link

mlegait commented Feb 7, 2022

Hi 😄

When do you plan to release a version with this fix?

@Andarist
Copy link
Member Author

Andarist commented Feb 7, 2022

@mlegait soon (today/tomorrow), let me just handle some other type-related stuff that could potentially go into the next patch release

For the time being, you can use skipLibCheck in your tsconfig.json (I feel like there is probably no reason to use its default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation issue with xstate@4.29.0 and typescript@4.5.5
3 participants