Fixed an issue with action objects not receiving correct event types #3090
Conversation
🦋 Changeset detectedLatest commit: 555d712 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 555d712:
|
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
packages/core/src/Machine.ts
Outdated
| TEvent, | ||
| ResolveTypegenMeta<TTypesMeta, TEvent, BaseActionObject, TServiceMap> | ||
| > | ||
| options?: TTypesMeta extends infer EvaluatedTypesMeta |
There was a problem hiding this comment.
This somehow forces TS to "evaluate" the final~ type for TTypesMeta quicker. My hunch is that it couldn't be discovered soon enough without typegen because tsTypes is an optional property, so it was missing then TS tried to "explore" the stuff further instead of using the fallback (TypegenDisabled default) immediately and then it couldn't compute stuff further down the road.
By doing it we kinda force it to utilize that TypegenDisabled default and it can proceed computing with that additional knowledge and that in turn allow for other stuff to be computed correctly.
packages/core/src/typegenTypes.ts
Outdated
| @@ -165,7 +165,7 @@ type AllowAllEvents = { | |||
| }; | |||
|
|
|||
| export type ResolveTypegenMeta< | |||
| TTypesMeta extends TypegenConstraint, | |||
| TTypesMeta, | |||
There was a problem hiding this comment.
ResolveTypegenMeta isn't supposed to be used publicly, so we can just trust its input. The problem was that after this infer trick above TS couldn't provide that the EvaluatedTypesMeta actually satisfies this constraint. An alternative approach to removing this generic would be to use Cast<EvaluatedTypesMeta, TypegenConstraint> at those "call sites". This seemed to be easier though.
Simplified demo of the problem:
TS playground
|
Ok, the CI has actually found some problems with this... so I'll have to convert this to a draft 😭 |
|
I think this might be a somewhat minimal repro for the problem: Can't be completely sure until this gets fixed in TS though. I will be investigating this further. |
…traint` when inferring for action object calls
|
That is wild... the workaround that I've discovered when debugging through TypeScript compiler... works. I feel like it's the greatest victory of man over a computer. Gonna be dancing to loud music today. |
# Conflicts: # packages/core/src/typegenTypes.ts # packages/core/test/types.test.ts
Andarist
force-pushed
the
andarist/fix-3026
branch
from
1fb870e
to
34a7ced
Compare
# Conflicts: # packages/core/test/types.test.ts
fixes #3026