Fixed an issue with onDone on parallel states with a history state not being called correctly
#3171
Conversation
…not being called correctly
🦋 Changeset detectedLatest commit: f9cbf74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9cbf74:
|
| return Object.keys(stateNode.states).map((key) => stateNode.states[key]); | ||
| return Object.keys(stateNode.states) | ||
| .map((key) => stateNode.states[key]) | ||
| .filter((sn) => sn.type !== 'history'); |
There was a problem hiding this comment.
It's a pseudostate and thus it's never really in the configuration, so it should always be just ignored, and not treated as one. This matches now the getChildStates procedure from SCXML
| @@ -68,10 +70,6 @@ export function getConfiguration<TC, TE extends EventObject>( | |||
| } else { | |||
| if (s.type === 'parallel') { | |||
| for (const child of getChildren(s)) { | |||
| if (child.type === 'history') { | |||
There was a problem hiding this comment.
It's now already filtered out by getChildren so this could be safely removed from here.
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
| @@ -18,7 +18,9 @@ export const isLeafNode = ( | |||
| export function getChildren<TC, TE extends EventObject>( | |||
There was a problem hiding this comment.
The biggest change caused by this that I've noticed is that now history states won't have .order set on them. That should be fine though because that's only used for sorting actions and history states can't have actions anyway
fixes #3170