Fixed a regression that caused child actors not being correctly stopped when their parent reached a final state #3523
Conversation
…ed when their parent reached a final state
🦋 Changeset detectedLatest commit: 4a46f25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👇 Click on the image for a new way to code review
Legend |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4a46f25:
|
| @@ -369,6 +369,7 @@ export class Interpreter< | |||
| listener(doneInvoke(this.id, doneData)); | |||
| } | |||
| this._stop(); | |||
| this._stopChildren(); | |||
There was a problem hiding this comment.
You might wonder why this can't be part of the _stop call as _stop gets called both:
- when reaching a final state
- when a machine gets stopped from the outside
The problem is that when .stop() (external call) gets called we first call _stop and then schedule an xstate.stop event. In this case, we should only stop children when we process that xstate.stop event and not immediately. This is mainly because exit actions should be able to send events to children. If we'd clear children in _stop then we would make this impossible.
closes #3522