Added package.json#exports to all packages
#3727
Conversation
🦋 Changeset detectedLatest commit: 76471fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76471fd:
|
👇 Click on the image for a new way to code review
Legend |
| @@ -13,6 +13,10 @@ | |||
| ], | |||
| "globals": { | |||
| "react": "React" | |||
| }, | |||
| "exports": true, | |||
| "___experimentalFlags_WILL_CHANGE_IN_PATCH": { | |||
There was a problem hiding this comment.
It's an opt-in flag that makes it possible to use the exports: true setting. package.json#exports can be convoluted and can be easily screwed up. We've done our best with Emma to implement something that works OK (while not allowing some things that people expected from us since they were more tricky and can't be safely enabled by all of the existing projects) but we couldn't be 100% sure that it would work with all of the available bundlers, node, etc.
So we've shipped this under an opt-in flag so it's more apparent that something could potentially break for the package consumers. I think that we did a pretty good job here though - considering that Emotion is using this for several months already and we didn't get any issue reports about stuff being broken (lately I found a bug in Vite's resolver but that's definitely their bug and not ours).
fixes #3350