Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inference for assign using PropertyAssigner #3818

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Feb 7, 2023

fixes #3151

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023

🦋 Changeset detected

Latest commit: 48b68ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Feb 7, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 48b68ff:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration
modest-shirley-m54p7g Issue #3151

assignment: Assigner<TContext, TEvent> | PropertyAssigner<TContext, TEvent>
assignment:
| Assigner<LowInfer<TContext>, TEvent>
| PropertyAssigner<LowInfer<TContext>, TEvent>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has some drawbacks when it comes to inferring standalone assigns, like here:

const a1 = assign(/*...*/)

When Assigner is used then it works just fine:

const a1 = assign((ctx: { counter: number }) => ({})) // TContext inferred to `{ counter: number }`

but when it comes to PropertyAssigner then it doesn't infer TContext and it leaves it as unknown (the internal partial assigned function stays types correctly, it's about what the typeof a1 is):

const a1 = assign({
  counter: (context: { counter: number }) => context.counter + 1,
})

It also doesn't work, in this context, with static values:

const a1 = assign({
  counter: 100,
})

I think that LowInfer combined with reverse mapped types is broken in TS, a minimal repro case of this can be found here: TS playground

@Andarist Andarist merged commit 2d8d84f into main Feb 9, 2023
@Andarist Andarist deleted the andarist/types-assign-with-static-values branch February 9, 2023 17:23
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Typescript issue assign with function and static value
2 participants