Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Remove state._sessionid #3890

Merged
merged 6 commits into from
Mar 17, 2023
Merged

[v5] Remove state._sessionid #3890

merged 6 commits into from
Mar 17, 2023

Conversation

davidkpiano
Copy link
Member

@davidkpiano davidkpiano commented Mar 13, 2023

This Pr removes state._sessionid. It is available on the actor: actor.sessionId

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

🦋 Changeset detected

Latest commit: 90fefe2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 90fefe2:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Mar 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@davidkpiano davidkpiano changed the title [v5] Rename state._sessionid to state.sessionId [v5] Remove state._sessionid Mar 14, 2023
'xstate': major
---

The `state._sessionid` property has been removed. It should be obtained directly from the actor: `actor.sessionId`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we even need to expose this anyhow on the actor - but we can bikeshed this later on.

@davidkpiano davidkpiano merged commit 3269374 into next Mar 17, 2023
@davidkpiano davidkpiano deleted the v5/sessionId branch March 17, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants