-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5] Final .data
to .output
#3952
Conversation
🦋 Changeset detectedLatest commit: 95d36cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 95d36cc:
|
// ... | ||
success: { | ||
- data: { message: 'Success!' } | ||
+ output: { message: 'Success!' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this later becomes part of the done.state.*
and done.invoe.*
events, should we rename the properties in those events as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I think there should be a difference between "this is the output of this machine" and "this is the data in this event". Not sure yet.
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
This PR renames
.data
to.output
on final states: