Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove State['event'] #4062

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Remove State['event'] #4062

merged 2 commits into from
Jun 13, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jun 7, 2023

No description provided.

@Andarist Andarist requested a review from davidkpiano June 7, 2023 11:11
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: ab0c786

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 7, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ab0c786:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Jun 7, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

davidkpiano
davidkpiano reviewed Jun 9, 2023
View reviewed changes
packages/xstate-test/test/dieHard.test.ts
Comment on lines +263 to +266
on: { NEXT_1: 'second' }
},
second: {
on: { NEXT: 'third' }
on: { NEXT_2: 'third' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the test work without these being renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's just that it wasn't obvious in the output which line refers to which transition. This change doesn't actually change anything, just improves~ the readability of the test

davidkpiano
davidkpiano approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@davidkpiano davidkpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changeset

@Andarist Andarist merged commit 28603a0 into next Jun 13, 2023
@Andarist Andarist deleted the remove-state-event branch June 13, 2023 13:08
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkpiano davidkpiano davidkpiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @davidkpiano