[v5] Allow guard objects to reference other guard objects #4064
Conversation
🦋 Changeset detectedLatest commit: 100932e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 100932e:
|
| ): GuardDefinition<TContext, TEvent> { | ||
| // TODO: do this recursively and check for cycles | ||
| if (isString(guardConfig)) { |
There was a problem hiding this comment.
All of this feels a tad complicated - but it's not exactly a unique problem to this function (similar things happen when "resolving" actions).
I think that the main mistake that we do here is that we try to resolve (through toGuardDefinition) too eagerly. We always need to have this resolution~ step when finally checking guards since we need to be inside the execution context of a machine. It's kinda pointless to resolve this twice.
Let's roll with this for now but I think that this should be flagged as something to refactor.
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
| expect(actorRef.getSnapshot().matches('b')).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should be possible to reference a composite guard that references other guards recursively', () => { |
There was a problem hiding this comment.
@davidkpiano you noted down in a code comment that we should handle things recursively but I pushed out some new tests here and this things seems to work. Am I missing some cases that you were thinking about?
There was a problem hiding this comment.
This still only goes one level deep; try something like:
guards: {
ref1: { type: 'ref2' },
ref2: { type: 'ref3' },
ref3: () => true
}Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
No description provided.