Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor callback logic to not send self-event #4509

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Refactor callback logic to not send self-event #4509

merged 8 commits into from
Nov 29, 2023

Commits on Nov 28, 2023

  1. Refactor callback logic to not send self-event

    @davidkpiano
    davidkpiano committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fcac7cf View commit details
    Browse the repository at this point in the history

  2. Changeset

    @davidkpiano
    davidkpiano committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ebb420d View commit details
    Browse the repository at this point in the history

  3. Attach to scope so @Andarist can fix it later

    @davidkpiano
    davidkpiano committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4bf3b40 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. use a WeakMap to keep callback instance around

    @Andarist
    Andarist committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2ca47f2 View commit details
    Browse the repository at this point in the history

  2. deduplicate observable event types

    @Andarist
    Andarist committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    62e8eaf View commit details
    Browse the repository at this point in the history

  3. unify promise event types with the convention used elsewhere

    @Andarist
    Andarist committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5de2dd4 View commit details
    Browse the repository at this point in the history

  4. add a tets case

    @Andarist
    Andarist committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f19020d View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/next' into v5/callback-refactor

    @Andarist
    Andarist committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    cd890d8 View commit details
    Browse the repository at this point in the history