Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with delayed transitions scheduling a delayed event for each transition defined for a single delay #888

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

Andarist
Copy link
Member

regression caused by #647
fixes #886

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2019

🦋 Changeset is good to go

Latest commit: 6b3d767

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -118,6 +118,36 @@ describe('delayed transitions', () => {
.start();
});

it('should defer a single send event for a delayed transition with multiple conditions (#886)', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not quite a good description - there are no multiple conditions defined here, but I'm having trouble with rephrasing this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either, this is fine for now.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5081248:

Sandbox Source
eager-boyd-rxmfj Configuration
hopeful-ellis-395nu Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b3d767:

Sandbox Source
blazing-http-i1ywb Configuration
peaceful-margulis-3xe2e Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(4.7.2) Conditional transitions break after delayed transition.
2 participants