Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix one parameter models #135

Merged
merged 1 commit into from
May 9, 2016
Merged

Fix one parameter models #135

merged 1 commit into from
May 9, 2016

Conversation

paulstaab
Copy link
Member

@paulstaab paulstaab commented May 9, 2016 •
edited
Loading

Currently, Jaatha throws an error in

assert_that(all(dim(start_pos) == c(reps, model$get_par_number())))

when used on a one parameter model with more than one repetition. This PR fixes the problem.

@paulstaab paulstaab added the bug label May 9, 2016
@paulstaab paulstaab added this to the Version 3.2.0 milestone May 9, 2016
@coveralls
Copy link

coveralls commented May 9, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 97.403% when pulling 852e951 on fix_one_par_models into 47e02c8 on master.

@paulstaab paulstaab merged commit 1ec85d4 into master May 9, 2016
@paulstaab paulstaab deleted the fix_one_par_models branch May 9, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulstaab @coveralls