build.sh: replace git protocol with https when cloning repos #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
approved these changes
Dec 16, 2022
|
Sure, no problem. |
|
@MichalHe, sorry for a late reply, can you please rebase this PR as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build symbiotic using the
build.shscript on a system withoutz3installed, the build fails on timeout while trying to cloneZ3Prover/z3repository. According to this GitHub post, the support forgit://protocol has been dropped, explaining the timeouts when cloningz3since the current repository URL uses thegit://protocol.This patch replaces all GitHub URLs that relied on the
git://protocol, with ones that usehttps://. This patch fixes a small typo in README.md. If it is undesired to have this change within one commit, there is no problem in splitting it into multiple commits.