Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Release 6.1.0 #55

Closed
alexkowa opened this issue Dec 18, 2020 · 5 comments
Closed

CRAN Release 6.1.0 #55

alexkowa opened this issue Dec 18, 2020 · 5 comments
Assignees
Milestone

Comments

@alexkowa
Copy link
Member

There are some smaller bug fixes since the last CRAN release. So it would be good to do a CRAN release rather soon.
What do you think? Is there anything we should wait on?

I moved the irmi new formula interface to 6.2.0, so @GregorDeCillia do you have time to work on this in the next 3 months?

@alexkowa alexkowa added this to the 6.1.0 milestone Dec 18, 2020
alexkowa added a commit that referenced this issue Dec 18, 2020
@GregorDeCillia
Copy link
Contributor

Yes, it should be possible to take care of #33 in Q1'2020.

I just looked at the commits since the last CRAN release 6.0.0 and there are in fact some changes that should be made available. The NEWS file also looks good. I don't see any reason to wait.

@matthias-da
Copy link
Collaborator

matthias-da commented Dec 29, 2020

I cannot build the current package because I receive a

 *** caught segfault ***
address 0x15970, cause 'memory not mapped'

Traceback:
 1: .Call("_VIM_gowerDind", PACKAGE = "VIM", dataX, dataY, weights,     ncolNUMFAC, levOrders, mixedConstants, nR, returnMinR)
 2: gowerDind(as.matrix(data.x), as.matrix(data.y), weights[weightind],     c(length(numerical), length(factors), length(orders), length(mixed)),     levOrders, mixed.constant, nMin, as.integer(returnMin))
 3: gowerD(don_dist_var, imp_dist_var, weights = weightsx, numericalX,     factorsX, ordersX, mixedX, levOrdersX, mixed.constant = mixed.constant,     returnIndex = TRUE, nMin = as.integer(k))
 4: dist_single(as.data.frame(don_dist_var), as.data.frame(imp_dist_var),     numericalX, factorsX, ordersX, mixedX, levOrdersX, don_index,     imp_index, weightsx, k, mixed.constant, provideMins = weightDist)
 5: kNN(x)

I use R 4.0.2 on OSX.
Strangely enough, the check does not report any problems.

If you have no problems to build the package, I suggest you send it to CRAN (and I will confirm).

@alexkowa
Copy link
Member Author

Sorry for the delay. So all looks fine to me (Ubuntu + Mac OS ).
@matthias-da I just pushed to R_devel and R_release on winbuilder. If the checks come back without problems, please publish https://github.com/statistikat/VIM/releases/download/6.1.0/VIM_6.1.0.tar.gz to CRAN.
Cheers, Alex

@alexkowa
Copy link
Member Author

@GregorDeCillia wil fix #56 very very soon, so let's just wait for that.

@alexkowa
Copy link
Member Author

on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants